Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby: 2.2.3 -> 2.2.5 and 2.1.7 -> 2.1.10 #17386

Merged
merged 2 commits into from
Sep 7, 2016
Merged

Conversation

vrthra
Copy link
Member

@vrthra vrthra commented Jul 30, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vrthra, thanks for your PR! By analyzing the annotation information on this pull request, we identified @zimbatm, @globin and @manveru to be potential reviewers

@vrthra
Copy link
Member Author

vrthra commented Jul 30, 2016

Error on travis was No space left on device for one. I am not quite sure why Darwin failed.

@vrthra vrthra changed the title ruby: 2.2.3 -> 2.2.5 ruby: 2.2.3 -> 2.2.5 and 2.1.7 -> 2.1.10 Jul 30, 2016
@fpletz fpletz added the 8.has: package (update) This PR updates a package to a newer version label Jul 31, 2016
@joachifm
Copy link
Contributor

joachifm commented Sep 4, 2016

Needs a rebase

@vrthra
Copy link
Member Author

vrthra commented Sep 7, 2016

I will update with a rebase soon. I am currently in a location with very sporadic internet access with limited bandwidth budget.

@vrthra
Copy link
Member Author

vrthra commented Sep 7, 2016

@joachifm I have updated the PR

@vrthra
Copy link
Member Author

vrthra commented Sep 7, 2016

@joachifm Ruby 1.x and 2.0.0 is EOLed Can they be removed from the pkgs/development/interpreters/ruby/default.nix? What are the guidelines for Nix packaging on removing old versions packages?

@fpletz
Copy link
Member

fpletz commented Sep 7, 2016

We usually remove software versions that are not maintained upstream anymore. One exception would be when there are still packages in nixpkgs depending on old versions that can't be fixed. As you're stepping up as maintainer (thanks btw!) I'll guess it's your decision now. ;)

Either way, this should be merged. 👍

@fpletz fpletz merged commit 6a11b81 into NixOS:master Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: ruby 8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants