Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webkitgtk: 2.10.4 -> 2.10.9 #17492

Merged
merged 1 commit into from
Aug 5, 2016
Merged

webkitgtk: 2.10.4 -> 2.10.9 #17492

merged 1 commit into from
Aug 5, 2016

Conversation

k0ral
Copy link
Contributor

@k0ral k0ral commented Aug 3, 2016

Motivation for this change

Solve #17308: upgrade webkitgtk 2.10 branch, and set default branch to 2.12 (transparent since no derivation was pointing to webkitgtk)

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested compilation of modified pkg
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Cc @RamKromberg

@mention-bot
Copy link

@k0ral, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ryantrinkle, @lethalman and @vcunat to be potential reviewers

@joachifm
Copy link
Contributor

joachifm commented Aug 4, 2016

This travis error looks legit: https://travis-ci.org/NixOS/nixpkgs/jobs/149596246. Big 👍 otherwise. Do you have a rough estimate of the amount of rebuilds this is likely to trigger? (Just in case it needs to go to staging first, I mean).

@vcunat
Copy link
Member

vcunat commented Aug 4, 2016

I don't think this should need to go through staging.

@k0ral
Copy link
Contributor Author

k0ral commented Aug 4, 2016

I've fixed the libobjc issue, now Travis fails because of what looks like a networking error.

@RamKromberg
Copy link
Contributor

RamKromberg commented Aug 5, 2016

Travis fails because of what looks like a networking error.

I'm guessing travis will fail regardless since the build will take too long.

I don't think this should need to go through staging.

I tend to agree seeing how no one can/will compile & test it unless it's available in binary form. Well, it's called unstable for a reason... :D

@joachifm
Copy link
Contributor

joachifm commented Aug 5, 2016

@RamKromberg the binaries produced while evaluating staging are still available, so it wouldn't make any difference in that respect, I think. Anyway, given the lack of objections to this, I think we should just go ahead.

@joachifm joachifm merged commit b7a4ef1 into NixOS:master Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants