-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt6.wrapQtAppsHook: remove dependencies: qtbase qtwayland #174946
qt6.wrapQtAppsHook: remove dependencies: qtbase qtwayland #174946
Conversation
A second thought on this lead me to believe that qtbase thould be removed from deps too. The hook itself does not require qtbase as a dep. |
A clean separation between the hook which runs on the buildPlatform, and qtbase on the hostPlatform would also make cross compilations eaiser, without having to deal with splicing and friends. |
45c6595
to
b870ac2
Compare
yes also tdesktop would have failed because |
qt6 gui apps: buildInputs: qtbase qtwayland qt6 cli apps: buildInputs: qtbase
b870ac2
to
784a633
Compare
So this doesn't have the advertised affect, and so perhaps this should be reverted, unless/until we find the problem. x-ref: #177530 (comment) If we do revert, we should make sure qtwayland is only added on linux. |
It has at least one effect: It reduces closure size and I would like to keep that. If qtwayland needs to be added back to the hook, we should think about an extra hook or make qtwayland optional. |
GUI applications are supposed to add qtwayland to buildInputs, see #174946 for details Co-authored-by: Janik H <janik@aq0.de>
Can we please remove the 'xcb' backends as well, as it bloats all qt derivations for me on wayland. As a matter of fact why do we not remove all platform plugin. Per default that seems to be eglfs, linuxfb, minimal, minimalegl, offscreen, vkkhrdisplay, vnc and xcb, so there is still a lot of bloat to remove. It might force users to rebuild all qt applications if they want to use qt at all, but it makes the derivation very small, which seems the main goal here. It is their fault to choose to run a bloaty graphical user interface to begin with. |
Description of changes
fix #174828
make dependencies explicit to reduce closure size for cli apps
qt cli apps:
buildInputs = [ qtbase ];
qt gui apps:
buildInputs = [ qtbase qtwayland ];
qt wrappers like pyqt or pyside: ?
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes