Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify update #17557

Merged
merged 2 commits into from
Aug 7, 2016
Merged

Spotify update #17557

merged 2 commits into from
Aug 7, 2016

Conversation

laMudri
Copy link
Contributor

@laMudri laMudri commented Aug 6, 2016

Motivation for this change

Spotify was updated, and old blob was removed from Spotify's site.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@laMudri, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rbvermaa, @sheenobu and @edolstra to be potential reviewers

@garbas garbas merged commit 687a012 into NixOS:master Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants