nixUnstable = nixStable #175603
Merged
nixUnstable = nixStable #175603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have regular (6-weekly) releases, there no longer is a compelling reason to have an unstable version of Nix in Nixpkgs. People who really need the bleeding edge can use the 'nix' flake.
|
👍🏽 and /cc PR #175541 |
trofi
approved these changes
May 31, 2022
bobby285271
added
the
12.approvals: 1
Artturin
reviewed
Jun 4, 2022
| sha256 = "sha256-RH77Y4IhbTofNYlLQSGKLL0fJAG9iHSwRNvMEZ4M0VQ="; | ||
| }; | ||
| }); | ||
| unstable = self.stable; |
There was a problem hiding this comment.
i'd prefer not to remove it but if it is wanted then this should be turned in to a throw alias that explains why it has been removed
There was a problem hiding this comment.
The title says "remove" but to me it's more like increasing version of nixUnstable to 2.8.
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-22.05
git worktree add -d .worktree/backport-175603-to-release-22.05 origin/release-22.05
cd .worktree/backport-175603-to-release-22.05
git checkout -b backport-175603-to-release-22.05
ancref=$(git merge-base f51cb36f2c98a991b8e4fbe257dc146577075f84 f888642ec69962a5da2e80c69b731d89e61f637d)
git cherry-pick -x $ancref..f888642ec69962a5da2e80c69b731d89e61f637d |
vcunat
added a commit
to vcunat/nixpkgs
that referenced
this pull request
Jun 12, 2022
On master we did this in f888642 in PR NixOS#175603, but on stable nixpkgs we surely don't want to advance nixStable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Now that we have regular (6-weekly) releases, there no longer is a compelling reason to have an unstable version of Nix in Nixpkgs. People who really need the bleeding edge can use the 'nix' flake.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes