Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stuntrally: 2.6.1 -> 2.6.2 #176001

Merged
merged 1 commit into from
Jun 8, 2022
Merged

stuntrally: 2.6.1 -> 2.6.2 #176001

merged 1 commit into from
Jun 8, 2022

Conversation

pSub
Copy link
Member

@pSub pSub commented Jun 2, 2022

This update also fixes the build problems
reported in #175646.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 2, 2022
@Artturin
Copy link
Member

Artturin commented Jun 4, 2022

Default stdenv has gcc11

Please remove the stdenv override from all-packages.nix

  stuntrally = callPackage ../games/stuntrally
    { stdenv = gcc10StdenvCompat; ogre = ogre1_9; mygui = mygui.override { withOgre = true; }; };

@Garmelon
Copy link
Contributor

Garmelon commented Jun 4, 2022

Compiles and runs fine.

This update also fixes the build problems
reported in #175646.
@pSub pSub force-pushed the update-and-fix-stuntrally branch from b5f38d2 to 788a347 Compare June 8, 2022 08:14
@pSub
Copy link
Member Author

pSub commented Jun 8, 2022

@Artturin Thank you for catching this!

@pSub pSub merged commit 4819590 into master Jun 8, 2022
@pSub pSub deleted the update-and-fix-stuntrally branch June 8, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants