Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffutils: 3.3 -> 3.4 #17629

Merged
merged 1 commit into from
Aug 10, 2016
Merged

diffutils: 3.3 -> 3.4 #17629

merged 1 commit into from
Aug 10, 2016

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 10, 2016

Motivation for this change

This causes 12000+ packages rebuild.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

See http://lists.gnu.org/archive/html/info-gnu/2016-08/msg00004.html
for release announcement.

@lsix lsix added 1.severity: mass-rebuild This PR causes a large number of packages to rebuild 8.has: package (update) This PR updates a package to a newer version labels Aug 10, 2016
@mention-bot
Copy link

@lancelotsix, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vcunat, @edolstra and @dezgeg to be potential reviewers

@edolstra edolstra merged commit 9c38161 into NixOS:master Aug 10, 2016
@dezgeg
Copy link
Contributor

dezgeg commented Aug 10, 2016

Doesn't this rebuild absoletely everything on master?

@copumpkin
Copy link
Member

Yes it does. @lancelotsix in future, perhaps better to submit PR against staging since you knew it was going to rebuild a lot of stuff.

@lsix
Copy link
Member Author

lsix commented Aug 10, 2016

Yes. sorry. I revert it from master and cherry-pick into staging shortly

@lsix lsix deleted the update_diffutils branch August 10, 2016 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: mass-rebuild This PR causes a large number of packages to rebuild 8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants