-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl: Add GnuTLS as an alternative to openSSL #17694
Conversation
@ikervagyok, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vcunat, @edolstra and @wkennington to be potential reviewers |
I'm fine with including an option for building with gnutls, but not including variants in |
@ikervagyok regarding your comment on building with libressl, it only needs overriding openssl with it so no other changes are necessary. Otherwise this looks fine since you've addressed @edolstra's comment, is it good to go from your side? |
@globin I have nothing, which explicitly needs curlLibreSSL, or any other fork to test such a case. So from my perspective it's good to go. Maybe later other people (or I) add more SSL/TLS implementations. |
@ikervagyok is there work to be done on this PR, or is it complete? |
(incl. a nitpick change from vcunat)
Merge-squash-ed and staged, with a minor nitpick changed. |
Looks like this was integrated. |
Oh, I forgot this. Maybe I even squashed the merge unintentionally. |
Motivation for this change
Added this option, as the game "Dont Starve" running in fhsUserEnv needs libcurl-gnutls.so.4, which we didn't have.
Also i find that having more choice regarding crypto(-libraries) is better.
It can be pulled even though it's marked WIP, but maybe we could/should add other libraries as well (libreSSL/...)
Things done
(nix.useChroot on NixOS,
or option
build-use-chroot
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)