Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: Add GnuTLS as an alternative to openSSL #17694

Closed
wants to merge 2 commits into from

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change

Added this option, as the game "Dont Starve" running in fhsUserEnv needs libcurl-gnutls.so.4, which we didn't have.
Also i find that having more choice regarding crypto(-libraries) is better.

It can be pulled even though it's marked WIP, but maybe we could/should add other libraries as well (libreSSL/...)

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ikervagyok, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vcunat, @edolstra and @wkennington to be potential reviewers

@edolstra
Copy link
Member

I'm fine with including an option for building with gnutls, but not including variants in all-packages.nix. That means more work for our build farm, and confusion for users (since nix-env -qa will show a bunch of apparently identical curl packages).

@globin
Copy link
Member

globin commented Aug 14, 2016

@ikervagyok regarding your comment on building with libressl, it only needs overriding openssl with it so no other changes are necessary.

Otherwise this looks fine since you've addressed @edolstra's comment, is it good to go from your side?

@ikervagyok
Copy link
Contributor Author

@globin I have nothing, which explicitly needs curlLibreSSL, or any other fork to test such a case. So from my perspective it's good to go. Maybe later other people (or I) add more SSL/TLS implementations.

@fpletz fpletz changed the title [WIP] curl: Add GnuTLS as an alternative to openSSL curl: Add GnuTLS as an alternative to openSSL Aug 15, 2016
@fpletz fpletz added the 1.severity: mass-rebuild This PR causes a large number of packages to rebuild label Aug 15, 2016
@grahamc
Copy link
Member

grahamc commented Oct 22, 2016

@ikervagyok is there work to be done on this PR, or is it complete?

@vcunat vcunat self-assigned this Feb 5, 2017
vcunat pushed a commit that referenced this pull request Feb 5, 2017
(incl. a nitpick change from vcunat)
@vcunat
Copy link
Member

vcunat commented Feb 5, 2017

Merge-squash-ed and staged, with a minor nitpick changed.

@joachifm
Copy link
Contributor

Looks like this was integrated.

@joachifm joachifm closed this Mar 25, 2017
@vcunat
Copy link
Member

vcunat commented Mar 25, 2017

Oh, I forgot this. Maybe I even squashed the merge unintentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: mass-rebuild This PR causes a large number of packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants