Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorio: Fix the fetch script #17741

Merged
merged 1 commit into from
Aug 14, 2016
Merged

factorio: Fix the fetch script #17741

merged 1 commit into from
Aug 14, 2016

Conversation

Baughn
Copy link
Contributor

@Baughn Baughn commented Aug 14, 2016

Motivation for this change

Login system changed.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.


This change is Reviewable

@mention-bot
Copy link

@Baughn, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rardiol to be a potential reviewer

@globin globin merged commit cbe8832 into NixOS:master Aug 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants