Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-sitter: add tree-sitter-tiger #177651

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

ambroisie
Copy link
Contributor

Description of changes

New grammar that I have written, will be making a PR to nvim-treesitter soon to add it there too.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ambroisie ambroisie requested review from ck3d, SuperSandro2000 and Profpatsch and removed request for ck3d June 14, 2022 14:50
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 14, 2022
@SuperSandro2000
Copy link
Member

Is there any rule to only include tree-sitter packages which are mentioned in the tree-sitter neovim readme?

@ambroisie
Copy link
Contributor Author

ambroisie commented Jun 14, 2022

Is there any rule to only include tree-sitter packages which are mentioned in the tree-sitter neovim readme?

I opened a PR to add the parser to nvim-treesitter, so it will be integrated in the plugin soon enough.

@teto
Copy link
Member

teto commented Jun 14, 2022

Is there any rule to only include tree-sitter packages which are mentioned in the tree-sitter neovim readme?

I dont think so, other programs use treesitter such as atom/helix/semantic/emacs/zed etc

@SuperSandro2000
Copy link
Member

Hmmm, I also don't think that it is a good sign that the repository is just a week old and has 0 stars on GitHub. I don't think we should add all our own and very tiny projects to nixpkgs. An overlay is a perfect place for such a package until it is majored a bit more.

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 15, 2022
@ambroisie
Copy link
Contributor Author

@SuperSandro2000 it has been added to nvim-treesitter, if that changes your opinion on whether it is worthy to be in nixpkgs.

@SuperSandro2000 SuperSandro2000 merged commit f448578 into NixOS:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants