Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: 2.14.1 -> 3.0, keep 2.14.1 #17766

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Gradle 3.0 release (https://docs.gradle.org/3.0/release-notes)

I kept 2.14.1 since there are a number of removals and deprecations in 3.0, which may break Gradle for projects depending on old features.

I did, however, change the package versioning scheme to be more explicit (gradle_2_5 over gradle25)

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@NeQuissimus, thanks for your PR! By analyzing the annotation information on this pull request, we identified @volhovm, @reltuk and @MarcWeber to be potential reviewers

@NeQuissimus
Copy link
Member Author

We are still ahead of the 16.09 cutoff, right? So this should make it into stable...

@NeQuissimus
Copy link
Member Author

@joachifm @zimbatm @grahamc You guys are the last three to have merged Gradle-related PRs. Could we make sure to get this into 16.09? :) I would really appreciate this.

@joachifm joachifm merged commit 56bfc02 into NixOS:master Aug 23, 2016
@NeQuissimus
Copy link
Member Author

Thank you :)

@NeQuissimus NeQuissimus deleted the gradle30 branch October 20, 2016 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants