Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmtouch: 1.0.2 -> 1.1.0 #17884

Merged
merged 1 commit into from
Aug 27, 2016
Merged

vmtouch: 1.0.2 -> 1.1.0 #17884

merged 1 commit into from
Aug 27, 2016

Conversation

garrison
Copy link
Member

@garrison garrison commented Aug 21, 2016

Motivation for this change

Upstream release

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm added the 8.has: package (update) This PR updates a package to a newer version label Aug 21, 2016
@garrison
Copy link
Member Author

garrison commented Aug 23, 2016

I am confused by the (rather cryptic) "Things done" checklist above. Are these items my responsibility as submitter of this pull request? I looked in CONTRIBUTING.md and "Chapter 11. Submitting changes" of the manual, and I am still unsure how to move forward.

@joachifm
Copy link
Contributor

@garrison those are mainly suggestions for things you should/could do to reduce the risk of breaking stuff and to eliminate some sources of impurities (aka packaging problems). Not all steps apply to all PRs. In the present case, you have indicated that this is a blind update.

@garrison
Copy link
Member Author

garrison commented Aug 27, 2016

Thanks @joachifm. I think I have checked the appropriate checkboxes now. As a meta issue, it would be really helpful for occasional contributors if this checklist were described in more detail [EDIT: either in CONTRIBUTING.md or in the manual]. I am still unsure from where I would run this nix-shell -p nox --run "nox-review wip" command.

@joachifm
Copy link
Contributor

@garrison Thank you. LGTM.

nox is typically run within your checkout. I don't think it's described very well anywhere, unfortunately. These days, travis is able to run nox fairly reliably and provides at least some protection against broken revdeps. I guess you'll have to use your own judgement as to the amount of breakage that may result from your update and whether running nox review locally is worth the cycles (it's incredibly slow, in my experience).

@joachifm joachifm merged commit c82d9e9 into NixOS:master Aug 27, 2016
@garrison garrison deleted the vmtouch-1.1.0 branch August 27, 2016 19:39
@garrison
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants