Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.django: 1.9.5 -> 1.9.9 and 1.8.12 -> 1.8.14 #17938

Merged
merged 2 commits into from
Aug 25, 2016

Conversation

kevinmarsh
Copy link
Contributor

Motivation for this change

Keeping up to date with latest bug fixes and security patches.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm joachifm added 6.topic: python 8.has: package (update) This PR updates a package to a newer version labels Aug 24, 2016
@FRidh
Copy link
Member

FRidh commented Aug 25, 2016

cc @lancelotsix

@FRidh
Copy link
Member

FRidh commented Aug 25, 2016

I suppose these also need to be backported to stable?

@lsix
Copy link
Member

lsix commented Aug 25, 2016

I am building and testing them locally.

Could the 2 updates (django_1_8 and django_1_9) be separated into 2 different commits?

@kevinmarsh
Copy link
Contributor Author

@lancelotsix no problem, I split them into separate commits

@lsix
Copy link
Member

lsix commented Aug 25, 2016

@kevinmarsh Could the commit messages be pythonPackages.django_1_8: 1.8.12 -> 1.8.14 and ``pythonPackages.django_1_9: 1.9.5 -> 1.9.9? pythonPackages.django` is an alias to django_1_10.

@lsix
Copy link
Member

lsix commented Aug 25, 2016

tested, merged and back ported to release-16.03.

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants