Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groonga: init at 6.0.7 #17983

Merged
merged 2 commits into from
Aug 25, 2016
Merged

groonga: init at 6.0.7 #17983

merged 2 commits into from
Aug 25, 2016

Conversation

ericsagnes
Copy link
Contributor

Motivation for this change

Add the Groonga search engine and one of its dependency.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Aug 25, 2016

:lgtm:

I verified both licenses, compiled and executed groonga.


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@grahamc grahamc merged commit 6bfe459 into NixOS:master Aug 25, 2016
@ericsagnes
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants