Python plover fix #18045
Merged
Python plover fix #18045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13833,23 +13833,28 @@ in modules // { | |||
|
|
|||
| plover = buildPythonPackage rec { | |||
| name = "plover-${version}"; | |||
| version = "3.0.0"; | |||
| version = "3.0.0+199"; | |||
| disabled = !isPy27; | |||
There was a problem hiding this comment.
if it is a release, then please us the full version of it. If it is a snapshot, then write plover-unstable-<date> following the updated guidelines.
|
Thank you for your detailed reply (pushed updated code), I seen on the Google groups of plover that the next version is close, so I think I'll just make this not an update but a fix. Mock is indeed a test dependency, so I see it should go into the buildInputs instead? Also, the xlib update got merged in with #18044, should I open a new PR with the PyPi source? |
KoviRobi
force-pushed
the
python-plover-update
branch
from
39c5013
to
7d73915
Compare
KoviRobi
force-pushed
the
python-plover-update
branch
from
7d73915
to
657724d
Compare
|
@KoviRobi is this ready to be integrated? |
|
@joachifm Yes, I have made it a fix instead of an update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes broken build (the added
patchPhase) and updates it. Update relies on #18044Things done
(nix.useChroot on NixOS,
or option
build-use-chrootinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)