Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropbox: 8.4.19 -> 8.4.21 #18079

Merged
merged 1 commit into from
Aug 29, 2016
Merged

dropbox: 8.4.19 -> 8.4.21 #18079

merged 1 commit into from
Aug 29, 2016

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Minor update and additionally we set proper permissions on the files in the output. Previously almost all the files were 0555, now they're 0444.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Additionally, we set proper permissions on the files in the output.
@mention-bot
Copy link

@peterhoeg, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ttuegel, @amiddelk and @abbradar to be potential reviewers

@globin globin merged commit da6e81f into NixOS:master Aug 29, 2016
@peterhoeg peterhoeg deleted the db_perms branch August 29, 2016 11:52
@ttuegel
Copy link
Member

ttuegel commented Aug 29, 2016

Did you also update the stable branch?

globin pushed a commit to mayflower/nixpkgs that referenced this pull request Aug 29, 2016
Additionally, we set proper permissions on the files in the output.
This was referenced Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants