rethinkdb: 2.3.4 -> 2.3.5

[rushmorem]

Things done

• Tested using sandboxing
  (nix.useChroot on NixOS,
  or option build-use-chroot in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • OS X
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[mention-bot]

@rushmorem, thanks for your PR! By analyzing the annotation information on this pull request, we identified @pikajude, @bluescreen303 and @thoughtpolice to be potential reviewers

[wmertens]

@rushmorem This is much more than a simple version bump, you are adding a Python dependency.

Why are you wrapping the start script with the Python package? It would be good if that bit got reverted.

[rushmorem]

@wmertens You are right. I should have mentioned this in my commit message. This is not just a version bump, it's also a bug fix. rethinkdb dump and rethinkdb restore commands (for backing up and restoring) require scripts that come with their official Python driver. This is why I had to package the driver pythonPackages.rethinkdb and wrap the rethinkdb command.

[wmertens]

aha awesome 👍 😄

[wmertens]

Could you put that in a comment in the derivation though? I can imagine a future maintainer removing that.

[rushmorem]

True. I will do that.