adb-sync: init at 2016-08-31 #18189
Merged
adb-sync: init at 2016-08-31 #18189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure looks unrelated to my eye (I hope so at least :-) ). |
|
that's indeed an unrelated issue. |
|
|
||
| installPhase = '' | ||
| mkdir -p $out/bin | ||
| cp $src/adb-channel $src/adb-sync $out/bin/ |
| mkdir -p $out/bin | ||
| cp $src/adb-channel $src/adb-sync $out/bin/ | ||
|
|
||
| sed -i '1s|/usr/bin/python|${python}/bin/python|' $out/bin/adb-sync |
There was a problem hiding this comment.
guess I didn't notice this before, but please use ${python.interpreter} instead of ${python}/bin/python. Also, I would expect the shebang already to be rewritten by patchShebangs.
There was a problem hiding this comment.
Ah, I didn't know about the existence of patchShebangs ; it's just awesome!
Replaced this line by an invocation of patchShebangs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package
adb-sync.Things done
(nix.useChroot on NixOS,
or option
build-use-chrootinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)