Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx: sphinx-1.3.6 test fixup #18197

Merged
merged 1 commit into from
Sep 1, 2016
Merged

Conversation

nand0p
Copy link
Contributor

@nand0p nand0p commented Sep 1, 2016

Motivation for this change:

FAIL: test_setup_command.test_build_sphinx_return_nonzero_status
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/zfmk6mqmr1046bh0cnh06frd0bb0nr20-python2.7-nose-1.3.7/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/tmp/nix-build-python2.7-Sphinx-1.3.6.drv-0/Sphinx-1.3.6/tests/test_setup_command.py", line 55, in deco
    func(pkgrootdir, proc)
  File "/tmp/nix-build-python2.7-Sphinx-1.3.6.drv-0/Sphinx-1.3.6/tests/test_setup_command.py", line 110, in test_build_sphinx_return_nonzero_status
    assert proc.returncode != 0, 'expect non-zero status for setup.py'
AssertionError: expect non-zero status for setup.py

Tested on Linux:

  • python 2.7
  • python 3.5

@ryansydnor @copumpkin @FRidh

Fixes this error:
```
FAIL: test_setup_command.test_build_sphinx_return_nonzero_status
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/zfmk6mqmr1046bh0cnh06frd0bb0nr20-python2.7-nose-1.3.7/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/tmp/nix-build-python2.7-Sphinx-1.3.6.drv-0/Sphinx-1.3.6/tests/test_setup_command.py", line 55, in deco
    func(pkgrootdir, proc)
  File "/tmp/nix-build-python2.7-Sphinx-1.3.6.drv-0/Sphinx-1.3.6/tests/test_setup_command.py", line 110, in test_build_sphinx_return_nonzero_status
    assert proc.returncode != 0, 'expect non-zero status for setup.py'
AssertionError: expect non-zero status for setup.py
```

Tested on Linux
- python 2.7
- python 3.5
@FRidh
Copy link
Member

FRidh commented Sep 1, 2016

$ nix-build -A pythonPackages.sphinx 
/nix/store/iwi9pxhsvv92lihwr46mvq1didzjas64-python2.7-Sphinx-1.3.6

This is on 255c9de.

You are not on NixOS, right?

@FRidh FRidh self-assigned this Sep 1, 2016
@nand0p
Copy link
Contributor Author

nand0p commented Sep 1, 2016

@FRidh I have not tested on NixOS. testing natively on centos7 (3.10.0-327.28.3.el7.x86_64 ) and ubuntu (stretch/sid 4.4.0-31-generic #50-Ubuntu). tested in vagrant and docker with centos7:latest.

for docker, i am testing with:

docker pull nand0p/nixpkgs-devel
docker run -ti nand0p/nixpkgs-devel bash
-> nix-build -A pythonPackages.sphinx
-> nix-build -A python3Packages.sphinx

i am seeing this FAIL: test_setup_command.test_build_sphinx_return_nonzero_status across the board

@FRidh FRidh merged commit f3e76de into NixOS:master Sep 1, 2016
@FRidh
Copy link
Member

FRidh commented Sep 1, 2016

really strange!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants