cheat: init at 2.1.26 #18554
cheat: init at 2.1.26 #18554
Conversation
|
@Mic92 judging from the description of this package it seems it is an application, and not a Python library. Or is it both? If it is used as an application only, it needs to be moved outside of |
|
|
||
| propagatedBuildInputs = with self; [ docopt pygments ]; | ||
|
|
||
| src = pkgs.fetchFromGitHub { |
There was a problem hiding this comment.
the package seems to be available on PyPI. For Python packages PyPI is the preferred source.
Mic92
force-pushed
the
cheat
branch
2 times, most recently
from
a50ec86
to
8505df5
Compare
|
fixed all concerns |
| @@ -6281,6 +6281,8 @@ in | |||
|
|
|||
| cgdb = callPackage ../development/tools/misc/cgdb { }; | |||
|
|
|||
| cheat = callPackage ../data/documentation/cheat { }; | |||
There was a problem hiding this comment.
data category is for data (not applications). A better place for cheat is applications/office or applications/misc (IMHO)
There was a problem hiding this comment.
I moved it to applications/misc now, it does definitely not belong to application/office. Its core asset are actually these short text files containing documentation like manpages or gnome-user-docs.
There was a problem hiding this comment.
application/misc is fine for me. Though, I should note that application/office doesn't mean application should deal with large nicely formatted documents and this kind of things.
In example, we currently have todo.txt-cli and tudu in application/office, which both are small apps for managing todo lists. There are also keepnote and eventlist, which are GUI apps for organizing other things.
There was a problem hiding this comment.
cheat is not a todo/note manager.
There was a problem hiding this comment.
IMHO, it's basically a note management software.
|
LGTM |
|
anything left to do? |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)