-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel-common: Add ZBUD #18661
kernel-common: Add ZBUD #18661
Conversation
@NeQuissimus, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @wkennington and @zohl to be potential reviewers |
Can you also make |
This sounds a bit like it's working around an upstream problem, either the kconfig dependencies should prevent an invalid configuration from being selected, or the code should cope with the default being a module. |
f664da6
to
6edce33
Compare
Hm, I've approved this prematurely because we need to test one more thing -- can you try to build |
Will kick off a kernel build in a minute... |
6edce33
to
77e1be3
Compare
I built 3.10, 3.12, 3.18 and 4.7. They all seem to build correctly now.
|
I think the Travis failures are timeouts, not actual errors |
@abbradar can this be merged? |
Motivation for this change
Fix #18533
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)I built a NixOS generation based on master with this change and the warnings mentioned in #18533 no longer appear.
Ping @abbradar