Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lato: init at 2.0 #18775

Merged
merged 1 commit into from
Sep 22, 2016
Merged

lato: init at 2.0 #18775

merged 1 commit into from
Sep 22, 2016

Conversation

chris-martin
Copy link
Contributor

Motivation for this change

Adds the Lato font.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz fpletz changed the title Lato: init at 2.0 lato: init at 2.0 Sep 21, 2016
@fpletz fpletz added the 8.has: package (new) This PR adds a new package label Sep 21, 2016
@fpletz
Copy link
Member

fpletz commented Sep 21, 2016

Hmm, should we maybe call the package lato-fonts or latofonts to find it easier when searching for fonts?

@chris-martin
Copy link
Contributor Author

chris-martin commented Sep 21, 2016

I'm not sure why the fonts aren't just under their own namespace e.g. fonts.lato in the same way that, say, pythonPackages are. I was just trying to follow the example of all the other font packages here.

@lucabrunox
Copy link
Contributor

Looks ok at the moment. The namespacing can be done as a separate issue.

@lucabrunox lucabrunox merged commit 9d99bba into NixOS:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants