-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clutter*, cogl: remove unused versions #18955
Conversation
@groxxda, thanks for your PR! By analyzing the annotation information on this pull request, we identified @lethalman, @urkud and @DamienCassou to be potential reviewers |
What did you test about this? Did you test gnome works? |
I tested the compilation with nox-review. Everything it picks up (including webkitgtk212) compiles fine. I'll cherry-pick my changeset on top of latest complete hydra build (b3d7ea), rebuild my desktop and check if it still works. I'm not using all of gnome but to me it looks like the list of gnome packages affected by this change is not that big. |
It's not always enough to build. Some apps or gnome itself is javascript, so you may see troubles only at runtime. Let me know if you are able to actually test your desktop. |
@lethalman from the travis log:
I recompiled my system and can confirm working:
I'm not certain how to test evolution data server. gnome-maps does not work:
but this is already happening on the commit I based my work on, so I believe this is unrelated. Anything else I should verify? |
Looks great, thanks! |
Motivation for this change
This switches to the new versions as default and removes the (now) unused old versions to clean up the clutter (how fitting 😆)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)#18952 should have helped avoiding this....
If you look at the changes, you'll see that I inherit from and to
all-packages
andgnome3
in both directions which would be avoided by reorganizing..I'll look into cleaning the remaining stuff (clutter, cogl, eventually vala) when I find time.
Note that I did not really change the
default.nix
files but rather did overwrite it with the newest versionCC @lethalman