Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maia-icon-theme: -> 2016-09-16 #19390

Merged
merged 1 commit into from
Oct 10, 2016
Merged

maia-icon-theme: -> 2016-09-16 #19390

merged 1 commit into from
Oct 10, 2016

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Oct 9, 2016

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add versioning using the date of revision on the git repository. Also
update to the latest revision, which includes a dark version of the icon
theme.

The cmake scripts install the icons at subdirectories 'maia' and
'maia-dark'. Also use these names. The difference is in the
capitalization of the names.

Add versioning using the date of revision on the git repository. Also
update to the latest revision, which includes a dark version of the icon
theme.

The cmake scripts install the icons at subdirectories 'maia' and
'maia-dark'. Also use these names. The difference is in the
capitalization of the names.
@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Mounium and @globin to be potential reviewers.

@joachifm
Copy link
Contributor

joachifm commented Oct 9, 2016

cc @Mounium

@joachifm joachifm closed this Oct 9, 2016
@joachifm joachifm reopened this Oct 9, 2016
@joachifm joachifm merged commit bc69fa8 into NixOS:master Oct 10, 2016
@romildo romildo deleted the fix.maia-icon-theme branch October 10, 2016 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants