Rename keepassx2-http to keepassx-reboot #19638
Conversation
|
@jonafato, thanks for your PR! By analyzing the history of the files in this pull request, we identified @s1lvester, @nbp and @aske to be potential reviewers. |
| name = "keepassx2-http-unstable-${version}"; | ||
| version = "2016-05-27"; | ||
| name = "keepassx-reboot-${version}"; | ||
| version = "2.0.3-http"; |
There was a problem hiding this comment.
Hi. Last time it was pointed out to me, that we shouldn't use these namespaces (I assume you're coming from arch too 😉 ) See. #17778 (diff) by @RamKromberg
I suggest we omit the ´-http´ since the packagename is different.
There was a problem hiding this comment.
2.0.3-http is the name of the tag being fetched from GitHub. If the version name is going to be a problem, I can decouple the version from the tag name. If it's not an issue, it's probably good to remain consistent with the source repository.
Let me know how I should proceed here.
There was a problem hiding this comment.
@s1lvester @jonafato actually things seem to be fine now as far as the parser is concerned:
$ nix-env -iA nixos.nix-repl
$ nix-repl
Welcome to Nix version 1.11.4. Type :? for help.
nix-repl> builtins.parseDrvName "keepassx-reboot-2.0.3-http"
{ name = "keepassx-reboot"; version = "2.0.3-http"; }
nix-repl> builtins.compareVersions "2.0.3-http" "2.0.3-http"
0
nix-repl> builtins.compareVersions "2.0.3-http" "2.0.4-http"
-1
nix-repl> builtins.compareVersions "2.0.4-http" "2.0.3-http"
1
Not sure about the conventions though...
p.s. There still problems when transitioning between formats:
nix-repl> nix-repl> builtins.compareVersions "2.0.4-http" "2.0.4"
1
nix-repl> builtins.compareVersions "2.0.4" "2.0.4-http"
-1
nix-repl> builtins.compareVersions "2.0.4" "2.0.6-http"
-1
nix-repl> builtins.compareVersions "2.0.4-http" "2.0.6"
-1
So those probably keep the conventions as is.
There was a problem hiding this comment.
@RamKromberg I've updated the commit to just use 2.0.3 as the version and ${version}-http for the current tag. This should account for new tags that will likely drop the -http suffix.
The `keepassx2-http` fork has been moved to a new organization and renamed to `keepassx-reboot`. For more details on the change, see the discussions in GitHub issues [1][2]. Included changes: - Rename the `keepassx2-http` package to `keepassx-reboot` - Fetch source from correct (moved) GitHub repository - Update the version to the latest release - Change the `homepage`, as these projects are likely to diverge over time - Add `keepassx2-http` to `aliases.nix [1] keepassx/keepassx#111 (comment) [2] keepassxreboot/keepassxc#40
jonafato
force-pushed
the
init-keepassx-reboot-2.0.3-http
branch
from
263f6ba
to
0bc1865
Compare
|
Ping @globin Can you merge this? |
Motivation for this change
The
keepassx2-httpfork has been moved to a new organization andrenamed to
keepassx-reboot. For more details on the change, see thediscussions in GitHub issues [1][2].
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Included changes:
keepassx2-httppackage tokeepassx-reboothomepage, as these projects are likely to diverge overtime
keepassx2-httpto `aliases.nix[1] keepassx/keepassx#111 (comment)
[2] keepassxreboot/keepassxc#40