Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_4_8: 4.8.1 -> 4.8.2 #19649

Merged
merged 1 commit into from
Oct 19, 2016
Merged

linux_4_8: 4.8.1 -> 4.8.2 #19649

merged 1 commit into from
Oct 19, 2016

Conversation

NeQuissimus
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus added 8.has: package (update) This PR updates a package to a newer version 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 18, 2016
@grahamc
Copy link
Member

grahamc commented Oct 18, 2016

I built all the changes between this and unstable, and every module which built on unstable built with this change. Some failed on unstable and with this change.

@NeQuissimus
Copy link
Member Author

@grahamc I don't understand what you are saying :)

@grahamc
Copy link
Member

grahamc commented Oct 18, 2016

I built all the changes between this and release-16.09, and every module which built on release-16.09 built with this change. Some failed on release-16.09 and with this change.

Sorry @NeQuissimus, let me clarify: I'm giving this a 👍 from me. I built all packages depending on your updates with your changes and without your changes. No additional modules were broken by this change, and no modules were fixed by this change. Same for #19648 and #19647.

@NeQuissimus NeQuissimus merged commit 84e4dcb into NixOS:master Oct 19, 2016
NeQuissimus added a commit that referenced this pull request Oct 19, 2016
linux_4_8: 4.8.1 -> 4.8.2
(cherry picked from commit 84e4dcb)
@NeQuissimus
Copy link
Member Author

Pretty sure I cherry-picked onto 16.09 (see 776ebeb)

@NeQuissimus NeQuissimus deleted the linux_4_8_2 branch October 19, 2016 18:50
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
linux_4_8: 4.8.1 -> 4.8.2
(cherry picked from commit 84e4dcb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants