Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium: Add desktop entry. #1970

Merged
merged 1 commit into from
Apr 21, 2014
Merged

Conversation

ambrop72
Copy link
Contributor

Tested, builds and appears in the menus.

@bjornfor
Copy link
Contributor

Will this collide with chromiumWrapper, which already provides a desktop entry?

@ambrop72
Copy link
Contributor Author

It may, I had no idea chromiumWrapper exists. I just put pkgs.chromium into systemPackages and assumed that the desktop entry is unimplemented because it wasn't installed.

So my pull should be abandoned. Instead I suggest fixing the naming to prevent any other such mishaps. I think 'chromium{,Beta,Dev}' should be the final wrapped version, and the current 'chromium{,Beta,Dev}' should be named differently.

@ambrop72
Copy link
Contributor Author

Also, it's not just the pkgs name, but also command-not-found. A "command-not-found chromium" should direct user to install the full thing with the desktop entry included. The only fix I can think of is for the wrapChromium to install a wrapper around the binary, and rename the chromium binary in the base package.

@bjornfor
Copy link
Contributor

(Oops, meant to press backspace and hit enter or something.)

I agree. The "chromium" attribute name and package name should be the thing that "just works" and what most people would want to install.

@aszlig aszlig self-assigned this Mar 16, 2014
@aszlig
Copy link
Member

aszlig commented Mar 16, 2014

Okay, going to merge #1733 as well, so I'll look into this and test command-not-found, thanks.

@ambrop72
Copy link
Contributor Author

I noticed the desktop file generated by the existing chromiumWrapper does not specify any mimeTypes. As such applications (in my case Konversation) won't pick it up as a handler for HTTP links. Gentoo uses:

MimeType=text/html;text/xml;application/xhtml+xml;x-scheme-handler/http;x-scheme-handler/https;x-scheme-handler/ftp;x-scheme-handler/mailto;x-scheme-handler/webcal

@kirelagin
Copy link
Member

I should probably point out that currently it's a little bit weird that you get a desktop entry only if you install Firefox/Chromium with plugins.

@shlevy
Copy link
Member

shlevy commented Mar 29, 2014

@aszlig Should this be closed, or merged?

@aszlig
Copy link
Member

aszlig commented Mar 29, 2014

Not sure yet what to do with the browser wrapper, but probably will merge this as well.

@aszlig aszlig added this to the 14.04 milestone Apr 19, 2014
aszlig added a commit to aszlig/nixpkgs that referenced this pull request Apr 20, 2014
We already have a desktop icon from the browser wrapper, so this is only
for people who do not use the wrapper (for example if you don't want to
use Mozilla plugins).

Also, we someday might want to propagate the desktop item to the browser
wrapper as well.

Conflicts:
	pkgs/applications/networking/browsers/chromium/default.nix
@aszlig aszlig merged commit 5533e05 into NixOS:master Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants