Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatbuffers #19720

Merged
merged 1 commit into from
Oct 20, 2016
Merged

Flatbuffers #19720

merged 1 commit into from
Oct 20, 2016

Conversation

teh
Copy link
Contributor

@teh teh commented Oct 20, 2016

Motivation for this change

This seems like an omission - self contained so should be low maintenance.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus
Copy link
Member

LGTM, would you like to adopt this package as a maintainer?

@NeQuissimus NeQuissimus added the 8.has: package (new) This PR adds a new package label Oct 20, 2016
@teh
Copy link
Contributor Author

teh commented Oct 20, 2016

Ah forgot that - added myself as a maintainer.

@NeQuissimus NeQuissimus merged commit b0f26b3 into NixOS:master Oct 20, 2016
@NeQuissimus
Copy link
Member

Awesome, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh @NeQuissimus