Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkvtoolnix: 9.4.2 -> 9.5.0 #19756

Merged
merged 1 commit into from
Oct 21, 2016
Merged

mkvtoolnix: 9.4.2 -> 9.5.0 #19756

merged 1 commit into from
Oct 21, 2016

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Oct 21, 2016

Motivation for this change

MKVToolNix v9.5.0 released

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rnhmjoj, @dguibert and @codyopel to be potential reviewers.

@NeQuissimus
Copy link
Member

Did you execute the binary to make sure it works?

@romildo
Copy link
Contributor Author

romildo commented Oct 21, 2016

I have executed the binary, and the GUI opens without problems. But I did not extensively test the functionality of the GUI, as there are many things it can do.

@NeQuissimus NeQuissimus merged commit 5df5198 into NixOS:master Oct 21, 2016
@romildo romildo deleted the upd.mkvtoolnix branch October 21, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants