Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchfile: remove unused file #19960

Merged
merged 1 commit into from
Oct 29, 2016
Merged

fetchfile: remove unused file #19960

merged 1 commit into from
Oct 29, 2016

Conversation

groxxda
Copy link
Contributor

@groxxda groxxda commented Oct 29, 2016

Motivation for this change

This file is not used and has invalid syntax.

CC @edolstra @7c6f434c

Things done

@mention-bot
Copy link

@groxxda, thanks for your PR! By analyzing the history of the files in this pull request, we identified @7c6f434c, @rick68 and @edolstra to be potential reviewers.

@vcunat
Copy link
Member

vcunat commented Oct 29, 2016

What's the invalid syntax?

@vcunat
Copy link
Member

vcunat commented Oct 29, 2016

BTW, if implementing this, it would be better to use a fixed-output derivation (instead of checking the hash manually).

@vcunat vcunat merged commit cc52371 into NixOS:master Oct 29, 2016
vcunat added a commit that referenced this pull request Oct 29, 2016
vcunat: it is unused, and it would better be implemented via a
fixed-output derivation instead of manually checking the hash
(if someone actually needed this).
@vcunat
Copy link
Member

vcunat commented Oct 29, 2016

Anyway, I don't think it's worth keeping it, at least in the current state.

@groxxda groxxda deleted the fetchfile branch October 29, 2016 15:54
@groxxda
Copy link
Contributor Author

groxxda commented Oct 29, 2016

@vcunat just for completeness: if is not valid after //.
Thanks for merging 👍

@vcunat
Copy link
Member

vcunat commented Oct 29, 2016

Ah, right, it was missing parentheses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants