Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: disable dbm support by default #21049

Merged
merged 1 commit into from
Jan 23, 2017
Merged

db: disable dbm support by default #21049

merged 1 commit into from
Jan 23, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Dec 10, 2016

Motivation for this change

I think that the patch I added before to fix the build with clang-3.8 broke dbm support.
It looks like none of our packages actually depend on it.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 1.severity: mass-darwin-rebuild This PR causes a large number of packages to rebuild on Darwin label Dec 10, 2016
@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @globin and @thoughtpolice to be potential reviewers.

@LnL7 LnL7 added 1.severity: mass-darwin-rebuild This PR causes a large number of packages to rebuild on Darwin and removed 1.severity: mass-darwin-rebuild This PR causes a large number of packages to rebuild on Darwin labels Dec 11, 2016
@LnL7 LnL7 changed the base branch from staging to master January 3, 2017 22:08
@LnL7 LnL7 removed the 1.severity: mass-darwin-rebuild This PR causes a large number of packages to rebuild on Darwin label Jan 4, 2017
@LnL7
Copy link
Member Author

LnL7 commented Jan 4, 2017

/cc @copumpkin

@LnL7 LnL7 changed the base branch from master to staging January 23, 2017 21:22
@LnL7 LnL7 merged commit dca3a4e into NixOS:staging Jan 23, 2017
@LnL7 LnL7 deleted the db-dbmsupport branch January 23, 2017 21:23
bendlas added a commit to bendlas/nixpkgs that referenced this pull request Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants