Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox-bin: fix updateScript #21064

Merged
merged 3 commits into from
Dec 14, 2016

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Dec 11, 2016

Motivation for this change

Extra double quotes in generated codes.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc: @garbas

@mention-bot
Copy link

@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @garbas, @mythmon and @edolstra to be potential reviewers.

@taku0
Copy link
Contributor Author

taku0 commented Dec 12, 2016

Changed from cat to mv (#21062 (comment)).

@taku0
Copy link
Contributor Author

taku0 commented Dec 13, 2016

Another fix. Maybe we should have tested it before pushing & merging.

@7c6f434c 7c6f434c merged commit d009ac1 into NixOS:master Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants