isl: add 0.17.1 #21066
Merged
isl: add 0.17.1 #21066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oups.
Mic92
reviewed
Dec 11, 2016
| @@ -2271,11 +2271,12 @@ in | |||
|
|
|||
| ised = callPackage ../tools/misc/ised {}; | |||
|
|
|||
| isl = isl_0_15; | |||
| isl = isl_0_17; | |||
| isl_0_11 = callPackage ../development/libraries/isl/0.11.1.nix { }; | |||
| isl_0_12 = callPackage ../development/libraries/isl/0.12.2.nix { }; | |||
There was a problem hiding this comment.
Do we need that many versions of this library?
There was a problem hiding this comment.
GCC and LLVM are the main users, and particular compiler versions need particular isl versions IIRC. Still, it's possible some of those isn't needed anymore.
There was a problem hiding this comment.
It looks like most of these are indeed specifically required by some existing package version:
- GCC 4.9 depends on 0.11.
- LLVM 3.4 relies on 0.12.
- GCC 5, 6 and LLVM 3.5 depend on 0.14.
There does not seem to be any direct dependence on isl_0_15, so I guess it could be simply replaced by isl_0_17.
|
Thanks! |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upgrade isl to the latest version.
@wkennington @globin @fpletz (Not sure whom to ping, here...)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)