Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haxe: enable darwin platform #21127

Merged
merged 1 commit into from
Dec 13, 2016
Merged

haxe: enable darwin platform #21127

merged 1 commit into from
Dec 13, 2016

Conversation

boronine
Copy link
Contributor

Motivation for this change

Darwin support for Neko is merged: #21072

This dependency was the only thing prohibiting Haxe from building on Darwin!

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@boronine, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nckx, @aszlig and @orbitz to be potential reviewers.

@globin globin merged commit 1beb9e6 into NixOS:master Dec 13, 2016
@boronine boronine deleted the haxe-enable-darwin branch February 10, 2017 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants