Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk-cpp: Enable on Darwin systems #21165

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Conversation

matthewbauer
Copy link
Member

Motivation for this change

aws-sdk-cpp was broken because libuuid wasn't available. Using libossp-uuid on OS X works great.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

libuuid can be provided by libossp_uuid.

@mention-bot
Copy link

@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @copumpkin and @pikajude to be potential reviewers.

libuuid can be provided by libossp_uuid.
@@ -195,7 +195,6 @@ let
CommonCrypto = applePackage "CommonCrypto" "osx-10.11.6" "0vllfpb8f4f97wj2vpdd7w5k9ibnsbr6ff1zslpp6q323h01n25y" {};
configd = applePackage "configd" "osx-10.8.5" "1gxakahk8gallf16xmhxhprdxkh3prrmzxnmxfvj0slr0939mmr2" {};
copyfile = applePackage "copyfile" "osx-10.11.6" "1rkf3iaxmjz5ycgrmf0g971kh90jb2z1zqxg5vlqz001s4y457gs" {};
CoreOSMakefiles = applePackage "CoreOSMakefiles" "osx-10.5" "0kxp53spbn7109l7cvhi88pmfsi81lwmbws819b6wr3hm16v84f4" {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear this was used at some point, but I can't find anything now. I wonder where it went!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, if you're going to get rid of this, I'd get rid of the associated Nix file as well.

Copy link
Member Author

@matthewbauer matthewbauer Dec 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops that shouldn't be in here! I'll open a separate pr for that and get rid of it here.

@Et7f3
Copy link
Contributor

Et7f3 commented Jan 31, 2023

Why was it reverted by ef65353 ?

It break darwin.opencflite:

$ nix build .#darwin.opencflite
error: value is null while a set was expected

       at /nix/store/bp70yjxsfkcamiq5m19phbkjk9rnrm61-source/pkgs/os-specific/darwin/opencflite/default.nix:12:37:

           11|
           12|   configureFlags = [ "--with-uuid=${libuuid.dev}" ];
             |                                     ^
           13|   buildInputs = [ icu tzdata.dev ];
(use '--show-trace' to show detailed location information)

@LnL7

I see the official implementation is open source https://github.com/apple-oss-distributions/xnu/blob/5c2921b07a2480ab43ec66f5b9e41cb872bc554f/libkern/uuid/uuid.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants