pythonPackages.livereload: init at 2.5.0 #21377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non-Jedi
force-pushed
the
pythonPackages.livereload
branch
from
2792f3a
to
4ae23aa
Compare
non-Jedi
commented
Dec 23, 2016
| name = "livereload-${version}"; | ||
| version = "2.5.0"; | ||
|
|
||
| src = pkgs.fetchFromGitHub { |
There was a problem hiding this comment.
Using fetchFromGitHub since the pypi package does not include tests.
There was a problem hiding this comment.
are the tests also run on all interpreter versions?
There was a problem hiding this comment.
You're right. Tests only run for python3. I'll take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Livereload is a dependency of statik static website generator, which I hope to include in nixpkgs.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)