Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use subcommands in plugin updaters #223164

Merged
merged 3 commits into from
Apr 14, 2023
Merged

use subcommands in plugin updaters #223164

merged 3 commits into from
Apr 14, 2023

Conversation

teto
Copy link
Member

@teto teto commented Mar 25, 2023

  • update.py: introduce subparsers for plugin updaters
  • doc/updaters: update command to update editor plugins
Description of changes

This is preliminary work to help create more powerful plugin updaters.
Namely I would like to be able to "just add" plugins without refreshing
the older ones (helpful when github temporarily removes a user from
github due to automated bot detection).

Also concerning the lua updater, we pin some of the dependencies, and I
would like to be able to unpin the package without editing the csv
(coming in later PRs).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

maintainers/scripts/pluginupdate.py Outdated Show resolved Hide resolved
maintainers/scripts/pluginupdate.py Outdated Show resolved Hide resolved
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--github-token doesn't seem to work anymore, at least for the vim update script

@teto
Copy link
Member Author

teto commented Apr 9, 2023

@figsoda this should be fixed. To sum up, the only effective change right now is instead do doing update.py --add XXX is that you should now run update.py add. The endgame is more ambitious but let's break stuff after the nixos release and not right before. Also I can't help but feel like we are recreating some abstraction over lockfiles. I feel like we should do it differently (more integration with nix-update or flakes or I dunno) but this should be adressed later.

@figsoda
Copy link
Member

figsoda commented Apr 9, 2023

thanks, I will test it out in a bit

This is preliminary work to help create more powerful plugin updaters.
Namely I would like to be able to "just add" plugins without refreshing
the older ones (helpful when github temporarily removes a user from
github due to automated bot detection).

Also concerning the lua updater, we pin some of the dependencies, and I
would like to be able to unpin the package without editing the csv
(coming in later PRs).
including vim, kakoune and lua packages
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@teto teto merged commit 351cec5 into NixOS:master Apr 14, 2023
@teto teto deleted the subcommand branch April 14, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants