Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heroku: 3.43.12 -> 3.43.16 #22341

Merged
merged 1 commit into from
Feb 1, 2017
Merged

heroku: 3.43.12 -> 3.43.16 #22341

merged 1 commit into from
Feb 1, 2017

Conversation

peterhoeg
Copy link
Member

Motivation for this change

This is the last version of the deprecated client but using the latest CLI.

We also lose the broken fhs wrapper script because the CLI is now compiled instead of just downloading the binary.

Fixes: #15262 and #20752

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aflatter to be a potential reviewer.

@rasendubi
Copy link
Member

rasendubi commented Feb 1, 2017

rasen@Larry ~/nixpkgs> ./result/bin/heroku
/usr/bin/env: ‘ruby’: No such file or directory

@rasendubi
Copy link
Member

Adding ruby to binPath helps, but now:

rasen@Larry ~/nixpkgs> ./result/bin/heroku 
 ▸    dashboard is not a heroku command.
 ▸    Perhaps you meant whoami?
 ▸    Run heroku _ to run heroku whoami.
 ▸    Run heroku help for a list of available commands.

(though, all other commands work fine.)

This is the last version of the deprecated client but using the latest CLI.
@peterhoeg
Copy link
Member Author

I have ruby in my global path, so maybe that's why it runs here without it. I have just added it in and running ./result/bin/heroku --help (and the other subcommands) work fine although I do get the peculiar message, when run without any arguments.

Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. (except when run without subcommand.)

@rasendubi rasendubi merged commit 7f3f30b into NixOS:master Feb 1, 2017
@peterhoeg peterhoeg deleted the f/heroku branch February 2, 2017 00:31
@peterhoeg peterhoeg restored the f/heroku branch February 2, 2017 00:44
@peterhoeg peterhoeg deleted the f/heroku branch February 3, 2017 08:48
@peterhoeg peterhoeg restored the f/heroku branch February 3, 2017 14:32
@peterhoeg peterhoeg deleted the f/heroku branch March 1, 2017 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants