Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages: Add tern #22418

Merged
merged 2 commits into from
Feb 4, 2017
Merged

nodePackages: Add tern #22418

merged 2 commits into from
Feb 4, 2017

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Feb 3, 2017

Motivation for this change

Add tern to nodePackages

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

sha1 = "9480ab20e94ffa1d9e80a804c7ea147611966b57";
};
};
"tapable-0.2.6" = {
Copy link
Member

@Mic92 Mic92 Feb 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case it complained, that tapable in this version was already defined in this file.

@jbaum98
Copy link
Contributor Author

jbaum98 commented Feb 4, 2017

@Mic92 thanks for the heads up, I pushed another commit that I think removed that duplication.

@Mic92 Mic92 merged commit 927b815 into NixOS:master Feb 4, 2017
@jbaum98
Copy link
Contributor Author

jbaum98 commented Feb 4, 2017

Is it an issue that even with the new commit the TravisCI build failed for one of the builds?

@jbaum98 jbaum98 deleted the tern branch February 4, 2017 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants