Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim-qt: works with qt 5.6 and msgpack 2.0 #22557

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

peterhoeg
Copy link
Member

Motivation for this change

neovim-qt was fixed against qt 5.5 and an older msgpack but works fine with the default 5.6 and msgpack 2.0

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Feb 10, 2017

Would you perhaps like to maintain this package?

@ttuegel ttuegel merged commit 05ecf91 into NixOS:master Feb 10, 2017
@peterhoeg
Copy link
Member Author

@FRidh, I pretty much live and breathe emacs, but as neovim-qt has no maintainer, sure, I'll take it on.

@peterhoeg peterhoeg deleted the f/neovim-qt branch February 10, 2017 18:01
@peterhoeg peterhoeg restored the f/neovim-qt branch February 10, 2017 18:11
@peterhoeg peterhoeg mentioned this pull request Feb 11, 2017
7 tasks
@peterhoeg peterhoeg deleted the f/neovim-qt branch February 11, 2017 03:45
@peterhoeg peterhoeg restored the f/neovim-qt branch February 11, 2017 05:46
@peterhoeg peterhoeg deleted the f/neovim-qt branch March 1, 2017 03:08
@peterhoeg peterhoeg restored the f/neovim-qt branch March 1, 2017 16:33
@peterhoeg peterhoeg deleted the f/neovim-qt branch March 2, 2017 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants