Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddy: set file descriptor limit to 8192, fixes #22454 #22647

Merged
merged 1 commit into from
Feb 11, 2017

Conversation

davidak
Copy link
Member

@davidak davidak commented Feb 11, 2017

Motivation for this change

the value is recommended for production use
a warning is produced when not set

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

the value is recommended for production use
a warning is produced when not set
@mention-bot
Copy link

@davidak, thanks for your PR! By analyzing the history of the files in this pull request, we identified @angus-g and @sheenobu to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Feb 11, 2017

Have you tested this change?

@davidak
Copy link
Member Author

davidak commented Feb 11, 2017

@grahamc just done. does what it should :)

@grahamc grahamc merged commit b5fb085 into NixOS:master Feb 11, 2017
@davidak davidak deleted the caddy-file-descriptor branch March 27, 2018 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants