sdl: fix very long filename #22654
Merged
sdl: fix very long filename #22654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @edolstra and @vcunat to be potential reviewers. |
vcunat
added
the
1.severity: mass-rebuild
vcunat
added a commit
that referenced
this pull request
Feb 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
SDL downloads a patch that ends up creating a file with a very long filename causing problems on installations where the nix store is not in /nix/store - #22643
This PR just uses a shorter name. I haven't recompiled all the dependencies as this change causes a massive rebuild.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)