Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R/generate-shell: Use R from current tree, fix missing wget dep. #23104

Merged
merged 1 commit into from
Feb 27, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 23, 2017

Without this change, the 'R' version used might be the wrong
one which changes the package lists used.

Fixes #19530.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Without this change, the 'R' version used might be the wrong
one which changes the package lists used.

Fixes NixOS#19530.
@FRidh
Copy link
Member

FRidh commented Feb 23, 2017

How is this file used? It looks to me like nothing more than an example.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 23, 2017

I believe it's meant to create the shell environment you use when running the package list generation scripts.

But the docs don't mention it (yet), see: #23069

@domenkozar domenkozar merged commit ffe935e into NixOS:master Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants