Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cura #23191

Merged
merged 5 commits into from
Feb 28, 2017
Merged

Update Cura #23191

merged 5 commits into from
Feb 28, 2017

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Feb 25, 2017

Motivation for this change

New versions of Cura and CuraEngine. Old versions are retained because they are quite different and needed for some printers.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @the-kenny -- I haven't added you to maintainers of new Cura -- one can call it another application because of all the differences. If you wish I can add you there.

@abbradar abbradar added the 8.has: package (update) This PR updates a package to a newer version label Feb 25, 2017
@mention-bot
Copy link

@abbradar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @the-kenny, @ambrop72, @dezgeg and @FRidh to be potential reviewers.

@abbradar
Copy link
Member Author

Tested on master with recent protobuf fix, works fine.

@abbradar abbradar merged commit b407e19 into NixOS:master Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants