gede: init at 2.0.3 #23229
Merged
gede: init at 2.0.3 #23229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Feb 27, 2017
| try: | ||
| shutil.copyfile("gede", g_dest_path + "/bin/gede") | ||
| - os.chmod(g_dest_path + "/bin/gede", 0775); | ||
| + os.chmod(g_dest_path + "/bin/gede", 775); |
There was a problem hiding this comment.
The argument to chmod needs to be octal:
In python3 this is done by prefixing 0o
os.chmod(g_dest_path + "/bin/gede", 0o755)
Mic92
reviewed
Feb 27, 2017
| configurePhase = ""; | ||
| buildPhase = ""; | ||
| installPhase = '' | ||
| ./build.py install --prefix=$out |
There was a problem hiding this comment.
It seems to me that you ported this script from python2 to python3. I think it is better if you send your changes upstream and keep the patch minimal (only qmake-qt4 -> qmake) by using python2 here for the meantime.
There was a problem hiding this comment.
Ok. I've switched to python2 and modified the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Init gede, a graphical frontent to GDB.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)