Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libseccomp: 2.3.1 -> 2.3.2 + fixed scmp_sys_resolver #23303

Merged
merged 1 commit into from
Mar 18, 2017

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Feb 28, 2017

Motivation for this change
  • libseccomp is updated to 2.3.2
  • scmp_sys_resolver is fixed (it could not find libseccomp.so.2 shared library before)

Up to now the scmp_sys_resolver command was not working because the bin could not find its shared lib :

[demo@nixos:~/testbuild/libseccomp]$ scmp_sys_resolver
scmp_sys_resolver: error while loading shared libraries: libseccomp.so.2: cannot open shared object file: No such file or directory`

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@c0bw3b, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @fpletz and @wkennington to be potential reviewers.


patchPhase = ''
patchShebangs .
'';

postInstall = ''
wrapProgram $out/bin/scmp_sys_resolver --prefix LD_LIBRARY_PATH ":" $out/lib
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That postInstall action can be reported on the previous version of the package on stable channels (16.09 and 17.03) in order to make the scmp_sys_resolver command work. It also needs the makeWrapper build input.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Feb 28, 2017

With the wrapProgram on scmp_sys_resolver :

[demo@nixos:~/testbuild/libseccomp]$ ./result/bin/scmp_sys_resolver 95
umask

@joachifm joachifm added the 8.has: package (update) This PR updates a package to a newer version label Mar 2, 2017
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Mar 5, 2017

@fpletz @thoughtpolice for reviewing this since you updated libseccomp before.
I haven't tried rebuilding the dependencies but the changelog does not contain anything 'disruptive'.

ChangeLog

Version 2.3.2 - February 27, 2017

  • Achieved full compliance with the CII Best Practices program
  • Added Travis CI builds to the GitHub repository
  • Added code coverage reporting with the "--enable-code-coverage" configure flag and added Coveralls to the GitHub repository
  • Updated the syscall tables to match Linux v4.10-rc6+
  • Support for building with Python v3.x
  • Allow rules with the -1 syscall if the SCMP_FLTATR_API_TSKIP attribute is set to true
  • Several small documentation fixes

`libseccomp` is updated to 2.3.2
`scmp_sys_resolver` is fixed (it could not find libseccomp.so.2 shared library before)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants