flashplayer: 24.0.0.221 -> 25.0.0.127 [Critical security fix]

[taku0]

Motivation for this change

• Critical security fixes.
• Other bug fixes.
• Separate HTTP and HTTPS permissions for Camera and Microphone

https://helpx.adobe.com/flash-player/release-note/fp_25_air_25_release_notes.html
https://helpx.adobe.com/security/products/flash-player/apsb17-07.html

Things done

• Tested using sandboxing
  (nix.useSandbox on NixOS,
  or option build-use-sandbox in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

Tested:

• Build packages
  • nix-env -i -f . -A pkgs.flashplayer
  • nix-build -I nixpkgs=. -A pkgsi686Linux.flashplayer
  • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"
  • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"
  • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone
  • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debugger
• Play a video with Firefox (x86_64)
• Check the version with Firefox (x86_64) http://www.adobe.com/software/flash/about/
• Play a flash animation with sound with flashplayer-standalone-debugger (x86_64)

---

[joachifm]

I'll cherry-pick as well.

[joepie91]

Has this made it into 16.09 yet? I'm still seeing the below when rebuilding:

curl: (22) The requested URL returned error: 404 Not Found
error: cannot download flash_player_npapi_linux.x86_64.tar.gz from any mirror
builder for ‘/nix/store/xyc6appv10076qla0s25bp1zbbj1whsc-flash_player_npapi_linux.x86_64.tar.gz.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/7k3q8ip9ckfc4v18kzm8258kla0hi0dc-flashplayer-24.0.0.221.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/j548rba5sr3m1r31j2qhb3b83892azw1-firefox-51.0.1.drv’: 1 dependencies couldn't be built

[Mic92]

@joepie91 its in the release branch of 16.09, maybe the channel is not finish building yet.

[joepie91]

Where can I track when it's finished building (to the point that it'll be available to install)? I've had to remove the Flash plugin from my configuration for the time being :/

[joachifm]

@joepie91 you can follow along at https://hydra.nixos.org/jobset/nixos/release-16.09, but it can be hard to predict when/if the channel will move forward. As an alternative, you can temporarily switch to a -small channel.

[kamilchm]

Can we have flashplayer in one reusable place? This is the second time I needed to patch chromium in a separate PR.