Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libextractor: 1.2 -> 1.3 #23941

Merged
merged 1 commit into from
Mar 16, 2017
Merged

libextractor: 1.2 -> 1.3 #23941

merged 1 commit into from
Mar 16, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 15, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @viric, @vcunat and @bjornfor to be potential reviewers.

@Mic92 Mic92 merged commit 1d36642 into NixOS:master Mar 16, 2017
@ndowens ndowens deleted the libextractor branch March 20, 2017 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndowens @mention-bot @Mic92