network-interfaces: restrict ipv6 udev rules #240295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface Only trigger the privacy address override for a given interface when that interface is added. Without restricting the rule to the interface, this command would be run when any interface is added.
rnhmjoj
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Tested with
networking.tempAddress = "default";
networking.interfaces.lo.tempAddress = "disabled";
It seems to be working as expected:
# sysctl net.ipv6.conf | grep tempaddr
net.ipv6.conf.default.use_tempaddr = 2
net.ipv6.conf.lo.use_tempaddr = 0
net.ipv6.conf.wlan0.use_tempaddr = 2
Thank you.
ctheune
added a commit
to flyingcircusio/nixpkgs
that referenced
this pull request
Apr 22, 2024
ctheune
added a commit
to flyingcircusio/nixpkgs
that referenced
this pull request
Apr 30, 2024
All network interface now use "-netdev.service" units, even if they have underlying physical devices and were previously depending on systemd device units. This proved to be unreliable when trying to transform systems between complex configuration states without requiring a reboot and ended up in undefined states. Includes a backport of NixOS#240295 Re PL-132441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The network-interfaces module generates udev rules to set IPv6 privacy address configuration on interfaces which have
networking.interfaces.<iface>.tempAddressset to a value other than the global default innetworking.tempAddresses. The generated udev rule for an interfaceethfoolooks like e.g.:However, this rule is missing a
NAME==constraint to restrict it to a matching an interface with a specific name, which means that it will get triggered for every new network interface added to the system, not onlyethfoo. This will result in the sysctl command being run once for every network interface attached to the system.This change adds an extra constraint to the generated udev rule, so that it is only triggered once by the interface to which it applies the sysctl configuration.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)