Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnu global: set path of default gtags.conf in wrapper #24057

Merged
merged 1 commit into from
Mar 19, 2017
Merged

gnu global: set path of default gtags.conf in wrapper #24057

merged 1 commit into from
Mar 19, 2017

Conversation

lpenz
Copy link
Contributor

@lpenz lpenz commented Mar 19, 2017

GNU global's gtags and global tools were unable to find the default
gtags.conf, necessary to use gtagslabels. The error could be seen
when gtags was invoked with -v:
$ gtags -v --gtagslabel=pygments
[Sun Mar 19 14:13:17 UTC 2017] Gtags started.
Using default configuration.
GTAGSLABEL(--gtagslabel) ignored since configuration file not found.
Using 'gtags.files' as a file list.
[Sun Mar 19 14:13:17 UTC 2017] Creating 'GTAGS' and 'GRTAGS'.
[Sun Mar 19 14:13:17 UTC 2017] Done.

The wrapper now points to the default gtags.conf using the
GTAGSCONF environment variable.

Motivation for this change

The gtagslabel option was not working - it was being silently ignored.
That would be reported when the -v flag was used, though.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

GNU global's gtags and global tools were unable to find the default
gtags.conf, necessary to use gtagslabels. The error could be seen
when gtags was invoked with -v:
$ gtags -v --gtagslabel=pygments
[Sun Mar 19 14:13:17 UTC 2017] Gtags started.
 Using default configuration.
 GTAGSLABEL(--gtagslabel) ignored since configuration file not found.
 Using 'gtags.files' as a file list.
[Sun Mar 19 14:13:17 UTC 2017] Creating 'GTAGS' and 'GRTAGS'.
[Sun Mar 19 14:13:17 UTC 2017] Done.

The wrapper now points to the default gtags.conf using the
GTAGSCONF environment variable.
@mention-bot
Copy link

@lpenz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @codyopel, @pSub and @jwiegley to be potential reviewers.

@pSub pSub merged commit 5f488bf into NixOS:master Mar 19, 2017
@lpenz lpenz deleted the gtagsconf branch March 19, 2017 17:21
@acowley acowley mentioned this pull request Jun 29, 2017
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants